-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Allow users to update volume name #4618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ravening I recall this being discussed before. is it a reopening with old code? |
|
yes, to answer my own question: #4584 |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2879 |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖️ centos7 ✔️ centos8 ✔️ debian. SL-JID 326 |
|
ping @ravening can you fix the conflicts |
|
Hi @ravening, Can you resolve the code conflicts. |
|
Hi @ravening can you please resolve the conflicts? |
@rhtyd @sureshanaparti @nvazquez will work on it today. |
|
@ravening ping - can you fix the conflict? You can enable email settings in your github https://github.com/settings/notifications |
@rhtyd yes thats all enabled.. no idea why its not sending notifications! |
Provide an api support to update volume name by all users
4da7a01 to
21f45d0
Compare
|
@blueorangutan package |
|
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
nvazquez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 919 |
|
@blueorangutan test |
|
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1706)
|
Provide an api support to update volume name by all users
UI changes ported from apache/cloudstack-primate#920
Description
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?