Skip to content

Conversation

@ravening
Copy link
Member

Provide an api support to update volume name by all users
UI changes ported from apache/cloudstack-primate#920

Description

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@ravening ravening mentioned this pull request Jan 26, 2021
12 tasks
@DaanHoogland
Copy link
Contributor

@ravening I recall this being discussed before. is it a reopening with old code?

@DaanHoogland
Copy link
Contributor

yes, to answer my own question: #4584

@shwstppr shwstppr added this to the 4.16.0.0 milestone Feb 8, 2021
@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2879

@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖️ centos7 ✔️ centos8 ✔️ debian. SL-JID 326

@rohityadavcloud
Copy link
Member

ping @ravening can you fix the conflicts

@sureshanaparti
Copy link
Contributor

Hi @ravening, Can you resolve the code conflicts.

@nvazquez
Copy link
Contributor

Hi @ravening can you please resolve the conflicts?

@ravening
Copy link
Member Author

Hi @ravening can you please resolve the conflicts?

@rhtyd @sureshanaparti @nvazquez will work on it today.
I didnt get any notification from github on tagging my username and so was unaware of this

@rohityadavcloud
Copy link
Member

@ravening ping - can you fix the conflict? You can enable email settings in your github https://github.com/settings/notifications

@ravening
Copy link
Member Author

@ravening ping - can you fix the conflict? You can enable email settings in your github https://github.com/settings/notifications

@rhtyd yes thats all enabled.. no idea why its not sending notifications!

Provide an api support to update volume name by all users
@nvazquez
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 919

@nvazquez
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-1706)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34257 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4618-t1706-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@nvazquez nvazquez merged commit ee01522 into apache:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants