-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](CostBasedRewriteJob)restore StatementContext.rewrittenCteProducer in CostBasedRewriteJob #59517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
englefly
wants to merge
1
commit into
apache:master
Choose a base branch
from
englefly:cte-producer-costrewrite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+63
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
6e97d27 to
073c151
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32774 ms |
TPC-DS: Total hot run time: 173200 ms |
ClickBench: Total hot run time: 26.79 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32270 ms |
TPC-DS: Total hot run time: 172742 ms |
ClickBench: Total hot run time: 27.06 s |
ef065c6 to
4438cb1
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32582 ms |
TPC-DS: Total hot run time: 173742 ms |
ClickBench: Total hot run time: 27.28 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cost based rewrite job may contaminate StatementContext.rewrittenCteProducer
fix solution: clone current rewrittenCteProducer, and restore it after each call to getCost(...)
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)