chore: add integration tests for subscribe_batch and project_by_name #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two new integration tests to improve API coverage: - test_subscribe_batch: tests LogScanner::subscribe_batch() with HashMap - test_project_by_name: tests TableScan::project_by_name() with column names Both tests include error case validation.
Author
|
Good morning and thanks for running the workflows! i updated the assertion to Note: clippy is pointing many more warnings in other tests, while this is still fine, its something that should be examinated in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_subscribe_batch: testsLogScanner::subscribe_batch()with HashMaptest_project_by_name: testsTableScan::project_by_name()with column namesLinked issue: #31