feat: add integration test for list offsets #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlospt
force-pushed
the
feat/add-it-for-list-offsets
branch
from
abb04b3 to
13abbda
Compare
luoyuxia
reviewed
Dec 22, 2025
Implements comprehensive integration test for list_offsets functionality covering earliest and latest offset queries before and after appending records. Changes: - Added list_offsets test with multiple scenarios: - List earliest offset on empty table (expected: 0) - List latest offset on empty table (expected: 0) - Append 3 records and verify latest offset updates to 3 - Verify earliest offset remains 0 after append - Test multi-bucket offset listing - Added OffsetSpec import for specifying offset types - Added table initialization delay to ensure table is ready Test validates that list_offsets correctly tracks record positions in the log and responds appropriately to Earliest and Latest queries. Fixes apache#47
pavlospt
force-pushed
the
feat/add-it-for-list-offsets
branch
from
13abbda to
b7912be
Compare
luoyuxia
force-pushed
the
feat/add-it-for-list-offsets
branch
from
fdae3f0 to
59dd702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds comprehensive integration test coverage for the
list_offsetsfunctionality, completing the requirements outlined in issue #47.Changes
list_offsets()integration test with comprehensive scenariosOffsetSpecimport for offset type specificationTest Coverage
The test validates:
Verification
cargo test --test test_fluss --features integration_tests list_offsetsTest passes successfully in ~25s.
Fixes #47