Skip to content

Conversation

@gkatzioura
Copy link
Contributor

@gkatzioura gkatzioura commented Nov 6, 2025

Purpose

Linked issue: close #1311

Add File System support for Azure Blob Storage.

Brief change log

Tests

API and Format

Documentation

@gkatzioura gkatzioura marked this pull request as draft November 6, 2025 08:46
@polyzos
Copy link
Contributor

polyzos commented Nov 6, 2025

@gkatzioura, you mean -> Add File System support for Azure Blob Storage?

@polyzos polyzos changed the title 1311 Azure Blob Storage Support 1311 Nov 6, 2025
@gkatzioura
Copy link
Contributor Author

@gkatzioura, you mean -> Add File System support for Azure Blob Storage?

Fixed

@luoyuxia
Copy link
Contributor

luoyuxia commented Nov 6, 2025

Just as #993 , obtainSecurityToken method is required for client to access Azure Blob Storage when read from remote

@gkatzioura
Copy link
Contributor Author

Just as #993 , obtainSecurityToken method is required for client to access Azure Blob Storage when read from remote

checking the options

@gkatzioura gkatzioura marked this pull request as ready for review December 1, 2025 07:40
@polyzos
Copy link
Contributor

polyzos commented Dec 1, 2025

@gkatzioura, we should make sure it works for all prefixes, like
https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/filesystems/azure/#azure-blob-storage

@polyzos
Copy link
Contributor

polyzos commented Dec 3, 2025

abfs:// works fine during my tests.

Screenshot 2025-12-03 at 11 28 12 AM

I pushed one commit to disable tests, because we can't meet the test coverage here, and I'm figuring out the issue with the license.

@gkatzioura
Copy link
Contributor Author

gkatzioura commented Dec 3, 2025

abfs:// works fine during my tests.

Screenshot 2025-12-03 at 11 28 12 AM I pushed one commit to disable tests, because we can't meet the test coverage here, and I'm figuring out the issue with the license.

Yes forgot to mention that I added the support for all formats

@polyzos
Copy link
Contributor

polyzos commented Dec 4, 2025

LicenseChecker fixed, and I just finished testing with all schemes. Everything works great 💪 🚀
@luoyuxia @michaelkoepf Let me know if you have any comments on this PR, before merging

@gkatzioura
Copy link
Contributor Author

Hi @luoyuxia
some observations on the obtainSecurityToken functionality.

I do receive the tokens when I read fluss data as a client

try (LogScanner logScanner = table.newScan().createLogScanner()) {
            logScanner.subscribeFromBeginning(1);
            var record = logScanner.poll(Duration.ofSeconds(10));
            record.forEach(r -> _ );
}

Once log scanner is started the tokens start to be sent.
However I could not see the tokens being shared above fluss components (tablet-server coordinator server).
Similar to what happens with Flink JobManager tokens delegated to the TaskManager.
My assumption was that the token is shared among the fluss components then it is used with a
hadoop custom provider type (Depends on the hadoop driver).

@luoyuxia
Copy link
Contributor

Hi @luoyuxia some observations on the obtainSecurityToken functionality.

I do receive the tokens when I read fluss data as a client

try (LogScanner logScanner = table.newScan().createLogScanner()) {
            logScanner.subscribeFromBeginning(1);
            var record = logScanner.poll(Duration.ofSeconds(10));
            record.forEach(r -> _ );
}

Once log scanner is started the tokens start to be sent. However I could not see the tokens being shared above fluss components (tablet-server coordinator server). Similar to what happens with Flink JobManager tokens delegated to the TaskManager. My assumption was that the token is shared among the fluss components then it is used with a hadoop custom provider type (Depends on the hadoop driver).

Hi, the security token is not shared above fluss components. Currently, it's only used by fluss-client, fluss-client require a token to read from remote directly.

Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkatzioura Thanks for the greate work! Left minor comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[file system] Add Azure Blob Storage

4 participants