feat: implement direct Avro encoder for performance #445
+1,002
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangxinli
force-pushed
the
avro_writer
branch
from
e9c1cbc to
2fec4dd
Compare
Implement direct Avro encoder to eliminate GenericDatum intermediate layer, matching the decoder approach for better performance. Implementation: - Add avro_direct_encoder_internal.h with EncodeArrowToAvro API - Add avro_direct_encoder.cc implementing direct Arrow→Avro encoding - All primitive types: bool, int, long, float, double, string, binary - Temporal types: date, time, timestamp - Logical types: uuid, decimal - Nested types: struct, list, map (both string and non-string keys) - Union type handling for optional fields - Modify avro_writer.cc to use DataFileWriterBase with direct encoder - Add EncodeContext to reuse scratch buffers and avoid allocations This matches Java Iceberg implementation using Encoder interface directly, avoiding intermediate object allocation overhead.
shangxinli
force-pushed
the
avro_writer
branch
from
2fec4dd to
8128b17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement direct Avro encoder to eliminate GenericDatum intermediate layer, matching the decoder approach for better performance.
Implementation:
This matches Java Iceberg implementation using Encoder interface directly, avoiding intermediate object allocation overhead.