Skip to content

fix: redirect only error output from makefile command to do not install uv if already present on system #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raulcd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: redirect only error output from makefile command to do not install uv if already present on system #2742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ help: ## Display this help message
##@ Setup

install-uv: ## Ensure uv is installed
@if ! command -v uv &> /dev/null; then \
@if ! command -v uv 2> /dev/null; then \
Copy link
Contributor

@kevinjqliu kevinjqliu Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@if ! command -v uv 2> /dev/null; then \
@if ! command -v uv > /dev/null 2>&1; then \

&> is bash-specific syntax. > /dev/null 2>&1 is POSIX-compliant and works across all shells, ensuring the Makefile is portable to systems where /bin/sh isn't bash (like Ubuntu's dash).

Same behavior, better compatibility.

echo "uv not found. Installing..."; \
curl -LsSf https://astral.sh/uv/install.sh | sh; \
else \
Expand Down