Skip to content

[flink] Fix that show partitions statements may not work for dv table. #6921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhoulii wants to merge 1 commit into
base: master
Choose a base branch
from
+33 −1
Open

[flink] Fix that show partitions statements may not work for dv table. #6921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/FlinkCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,10 @@
import org.apache.paimon.table.FormatTable;
import org.apache.paimon.table.Table;
import org.apache.paimon.table.sink.BatchTableCommit;
import org.apache.paimon.table.source.DataTableScan;
import org.apache.paimon.table.source.ReadBuilder;
import org.apache.paimon.utils.FileStorePathFactory;
import org.apache.paimon.utils.Filter;
import org.apache.paimon.utils.InternalRowPartitionComputer;
import org.apache.paimon.utils.Preconditions;
import org.apache.paimon.utils.StringUtils;
Expand Down Expand Up @@ -1227,7 +1229,8 @@ private List<PartitionEntry> getPartitionEntries(
if (partitionSpec != null && partitionSpec.getPartitionSpec() != null) {
readBuilder.withPartitionFilter(partitionSpec.getPartitionSpec());
}
return readBuilder.newScan().listPartitionEntries();
DataTableScan tableScan = (DataTableScan) readBuilder.newScan();
return tableScan.withLevelFilter(Filter.alwaysTrue()).listPartitionEntries();
}

private List<CatalogPartitionSpec> getPartitionSpecs(
Expand Down
29 changes: 29 additions & 0 deletions ...n-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/CatalogTableITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,35 @@ public void testShowPartitions() {

result = sql("SHOW PARTITIONS PartitionTable partition (dt='2020-01-02', hh='11')");
assertThat(result).containsExactlyInAnyOrder(Row.of("dt=2020-01-02/hh=11"));

sql(
"CREATE TABLE PartitionTableWithDVEnabled (\n"
+ " user_id BIGINT,\n"
+ " item_id BIGINT,\n"
+ " behavior STRING,\n"
+ " dt STRING,\n"
+ " hh STRING,\n"
+ " PRIMARY KEY (dt, hh, user_id) NOT ENFORCED\n"
+ ") PARTITIONED BY (dt, hh) WITH ('deletion-vectors.enabled'='true', 'write-only'='true')");
sql("INSERT INTO PartitionTableWithDVEnabled select 1,1,'a','2020-01-01','10'");
sql("INSERT INTO PartitionTableWithDVEnabled select 2,2,'b','2020-01-02','11'");
sql("INSERT INTO PartitionTableWithDVEnabled select 3,3,'c','2020-01-03','11'");
result = sql("SHOW PARTITIONS PartitionTableWithDVEnabled");
assertThat(result)
.containsExactlyInAnyOrder(
Row.of("dt=2020-01-01/hh=10"),
Row.of("dt=2020-01-02/hh=11"),
Row.of("dt=2020-01-03/hh=11"));

result = sql("SHOW PARTITIONS PartitionTableWithDVEnabled partition (hh='11')");
assertThat(result)
.containsExactlyInAnyOrder(
Row.of("dt=2020-01-02/hh=11"), Row.of("dt=2020-01-03/hh=11"));

result =
sql(
"SHOW PARTITIONS PartitionTableWithDVEnabled partition (dt='2020-01-02', hh='11')");
assertThat(result).containsExactlyInAnyOrder(Row.of("dt=2020-01-02/hh=11"));
}

@Test
Expand Down