[UNOMI-923] Avoid install already installed features and start already started features #745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the feature installation and tracking logic in the
UnomiManagementServiceImplclass to improve clarity and reliability. The changes primarily focus on renaming variables for better intent, ensuring features are only installed or started when appropriate, and making feature state transitions more robust.Feature tracking and naming improvements:
installedFeaturesandstartedFeatureslists totrackedInstalledFeaturesandtrackedStartedFeaturesfor clearer intent and to avoid confusion with Karaf's internal feature tracking.Feature installation and startup logic:
trackedStartedFeatureslist and to ensure features are only started if required.Feature stopping and uninstalling:
Feature state transition safety:
startFeatureandstopFeaturemethods to check the current feature state before attempting to start or stop, preventing unnecessary state changes and potential errors.