Skip to content

Conversation

@kortemik
Copy link

…sion:hadoop-lzo:jar:0.4.19, see https://www.gnu.org/licenses/quick-guide-gplv3.html

What is this PR for?

Change license to be compatible with license of com.hadoop.gplcompression:hadoop-lzo:jar:0.4.19
https://github.com/twitter/hadoop-lzo/blob/master/src/main/java/com/hadoop/compression/lzo/CChecksum.java#L4-L7

see https://www.gnu.org/licenses/quick-guide-gplv3.html

What type of PR is it?

[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
Hot Fix

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-5033

How should this be tested?

Purpose of this pull request is to deepen the discussion needed regarding this issue.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update?
    Yes
  • Is there breaking changes for older versions?
  • Does this needs documentation?

@Reamer
Copy link
Contributor

Reamer commented Sep 10, 2020

Hi @kortemik,
Can you give us a hint where the Zeppelin integrates Hadoop-lzo?

@kortemik
Copy link
Author

Hi,

I think Scalding interpreter pulls it as a dependency:
[INFO] Including com.hadoop.gplcompression:hadoop-lzo:jar:0.4.19 in the shaded jar.

@Reamer
Copy link
Contributor

Reamer commented Sep 10, 2020

You are right.
By the way, Scalding itself is licensed under the Apache License 2.0. https://github.com/twitter/scalding/blob/develop/LICENSE
The library was added with the commit in scaling. twitter/scalding@92a633d

I am far from being a licensing expert, but maybe you can address a similar problem in the Scaling project.

@kortemik
Copy link
Author

There we have it twitter/scalding#1932 (:

@github-actions
Copy link

This pull request has been inactive for over a year. If no further activity occurs within the next 30 days, it will be automatically closed. If you believe this PR is still relevant, please feel free to leave a comment or make an update. Thank you!

@github-actions github-actions bot added the Stale label Jul 18, 2025
@github-actions
Copy link

This pull request has been automatically closed due to prolonged inactivity (over one year without updates). If you feel this was done in error or would like to continue the discussion, feel free to reopen it. Thank you for your contributions!

@github-actions github-actions bot closed this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants