Kubectl volsync rsync tls

[tesshuflower]

Describe what this PR does

• Implements kubectl-volsync migration and replication for rsync-tls.

Migration for rsync-tls will require having stunnel installed locally.

• Also has a fix for migration to set the default replicationdestination name to something shorter, and allow optionally passing in the rdname as a parameter.

Is there anything that requires special attention?

• Versioned the data structure to v2 to try to keep all params saved in the data structure identical for rsync and rsync-tls and have an option for rsync-tls enabled
• rsynctls is currently defaulted to false
• When loading v1, automatically convert it to v2 and proceed.
• it's a bit messy with all the new parameters, hopefully not too confusing.
• implemented an rsync and rsync-tls version of handlers in an attempt to separate them - will make it easier to remove rsync too if we ever get to that point.
• Testing particularly on the cli migration side isn't great, but at least was able to add new e2e tests for cli replication.

Related issues:
#369
#1075

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tesshuflower]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.6% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

[JohnStrunk]

I really am going to review this. 😢

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

[codecov]

Codecov Report

❌ Patch coverage is 29.36596% with 635 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.1%. Comparing base (5272a5f) to head (db27593).
⚠️ Report is 381 commits behind head on main.

Files with missing lines	Patch %	Lines
kubectl-volsync/cmd/migration_handler_rsynctls.go	15.2%	200 Missing and 6 partials ⚠️
...ubectl-volsync/cmd/replication_handler_rsynctls.go	0.0%	111 Missing ⚠️
kubectl-volsync/cmd/migration_handler_rsync.go	22.8%	102 Missing and 6 partials ⚠️
kubectl-volsync/cmd/replication_handler_rsync.go	0.0%	105 Missing ⚠️
kubectl-volsync/cmd/tls_cli_flag_utils.go	64.2%	20 Missing and 10 partials ⚠️
kubectl-volsync/cmd/replication_setDestination.go	13.0%	20 Missing ⚠️
kubectl-volsync/cmd/replication_setSource.go	14.2%	18 Missing ⚠️
kubectl-volsync/cmd/migration_create.go	70.7%	9 Missing and 3 partials ⚠️
kubectl-volsync/cmd/replication.go	81.1%	9 Missing and 1 partial ⚠️
kubectl-volsync/cmd/migration_rsync.go	53.8%	6 Missing ⚠️
... and 2 more

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #1238     +/-   ##
=======================================
- Coverage   67.5%   65.1%   -2.4%     
=======================================
  Files         57      62      +5     
  Lines       7584    8170    +586     
=======================================
+ Hits        5123    5324    +201     
- Misses      2161    2526    +365     
- Partials     300     320     +20     

Files with missing lines	Coverage Δ
kubectl-volsync/cmd/migration_delete.go	44.4% <100.0%> (+12.7%)	⬆️
kubectl-volsync/cmd/migration.go	75.7% <90.0%> (+15.9%)	⬆️
kubectl-volsync/cmd/migration_rsync.go	19.6% <53.8%> (+13.7%)	⬆️
kubectl-volsync/cmd/replication_create.go	52.2% <77.7%> (+40.5%)	⬆️
kubectl-volsync/cmd/replication.go	62.5% <81.1%> (+25.4%)	⬆️
kubectl-volsync/cmd/migration_create.go	57.2% <70.7%> (+0.5%)	⬆️
kubectl-volsync/cmd/replication_setSource.go	14.5% <14.2%> (+1.2%)	⬆️
kubectl-volsync/cmd/replication_setDestination.go	15.9% <13.0%> (+0.8%)	⬆️
kubectl-volsync/cmd/tls_cli_flag_utils.go	64.2% <64.2%> (ø)
kubectl-volsync/cmd/replication_handler_rsync.go	0.0% <0.0%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

[sonarqubecloud]

Quality Gate failed

Failed conditions
4 Security Hotspots

See analysis details on SonarQube Cloud

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.