Skip to content
This repository was archived by the owner on Nov 4, 2023. It is now read-only.

Conversation

@skn3
Copy link

@skn3 skn3 commented Jul 16, 2014

Hey Mark,

The "ANDROID_MAINFEST_ACTIVITY_PROPERTIES" needs to be replicated into the android_ndk target.

added gitignore .build
added androidmanifest and transcc var ANDROID_MAINFEST_ACTIVITY_PROPERTIES

skn3 added 3 commits July 16, 2014 09:56
added androidmanifest and transcc var ANDROID_MAINFEST_ACTIVITY_PROPERTIES
@skn3
Copy link
Author

skn3 commented Jul 16, 2014

Also added small tweak to FixDataPath so it doesn't mangle paths starting with ~

@skn3
Copy link
Author

skn3 commented Jul 16, 2014

Made FixPath public so we can manually use monkey compatible paths (monkey://blah) from 3rd party modules.

@blitz-research
Copy link
Owner

FixPath is a bit vague - perhaps FilePath? FileSystemPath?

mojo FixDataPath needs to go! mojo file paths shouldn't be different from
'other' file paths - ie: the paths you pass to DataBuffer.Load should be
handled the same as the paths you pass to LoadImage.

All would work more or less equivalently if app currentdir started in
'data' dir. ChangeDir would then 'break' LoadImage( "blah" ) if blah were
in data dir, but user just needs to use monkey://data/blah instead. Need to
think about this a bit more when I get a chance.

On Thu, Jul 17, 2014 at 2:34 AM, Jonathan notifications@github.com wrote:

Made FixPath public so we can manually use monkey compatible paths
(monkey://blah) from 3rd party modules.


Reply to this email directly or view it on GitHub
#61 (comment).

@skn3
Copy link
Author

skn3 commented Jul 17, 2014

FileSystemPath sounds good. Is this something I should change on my repo or are you going to merge the other changes and then rename?

I am using it in a module called imagecache. Essentially it lets you do threaded download of images. It also allows you to load/save monkey images too. I use a similar technique with a webview module I made to take snapshots of the webview and then load/save them as monkey images.

Unfortunately this require two changes to the image surface class to add a GetSurface() and GetSurfaceDimensions(). Is this something you will see supporting in monkey ever? (probably a bit off topic)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants