Make basic_static_string constructible and assignable from a C-style string in a constexpr context
#78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gennaroprota
force-pushed
the
issue#55
branch
2 times, most recently
from
6bec231 to
dec79a8
Compare
… C-style string in a constexpr context This triggers a libstdc++ issue which was fixed in GCC 12.4 and 13.3: <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113200>. If our CI shows we bump into that bug, we'll add a workaround.
gennaroprota
force-pushed
the
issue#55
branch
3 times, most recently
from
6636129 to
f86b0c1
Compare
gennaroprota
changed the title
constexpr basic_static_string s("...")basic_static_string constructible and assignable from a C-style string in a constexpr context
See the previous commit. This simple fix avoids calling Traits::move(), which is where the bug resides. This closes issue #55.
gennaroprota
force-pushed
the
issue#55
branch
from
f86b0c1 to
119eab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructing or assigning from a C-style string in a constexpr context triggers a libstdc++ issue which was fixed in GCC 12.4 and 13.3: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113200. We add corresponding tests, and then a workaround for the issue.