Skip to content

Conversation

@yssambare12
Copy link
Contributor

  • CF-50 - Fixed - Two word google fonts not applying proplery

Copilot AI review requested due to automatic review settings December 19, 2025 11:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes an issue where Google Fonts with two-word names were not applying correctly. The fix involves properly URL-encoding font file paths and changing how font names are extracted from the filesystem.

Key changes:

  • Implemented proper URL encoding for font file paths by encoding each path segment individually
  • Changed font name extraction to use folder names instead of parsing filenames
  • Updated regex pattern for font file matching to be more strict and anchored

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
includes/class-bcf-google-fonts-compatibility.php Added URL encoding logic to properly encode font file paths with spaces or special characters in both update_fse_theme_json() and process_google_fonts_locally() methods
classes/class-bsf-custom-fonts-render.php Updated URL encoding for font URLs, refined regex pattern for font file matching, and changed font name extraction to use folder names instead of filename parsing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants