Skip to content

Removed being verb from NumberPreposition (5m) #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ben5516 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed being verb from NumberPreposition (5m) #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions lib/set_builder/modifiers/number_preposition.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,24 +9,24 @@ class NumberPreposition < Modifier::Verb

def self.operators
{
:is => [:number],
:is_less_than => [:number],
:is_greater_than => [:number],
:is_between => [:number, :number]
:exactly => [:number],
:less_than => [:number],
:greater_than => [:number],
:between => [:number, :number]
}
end



def build_conditions_for(selector)
case operator
when :is
when :exactly
["#{selector}=?", value]
when :is_less_than
when :less_than
["#{selector}<?", value]
when :is_greater_than
when :greater_than
["#{selector}>?", value]
when :is_between
when :between
["#{selector}>=? AND #{selector}<=?", values[0], values[1]]
end
end
Expand All @@ -35,13 +35,13 @@ def build_conditions_for(selector)

def build_arel_for(selector)
case operator
when :is
when :exactly
selector.eq(value)
when :is_less_than
when :less_than
selector.lt(value)
when :is_greater_than
when :greater_than
selector.gt(value)
when :is_between
when :between
selector.gteq(values[0]).and(selector.lteq(values[1]))
end
end
Expand Down
8 changes: 4 additions & 4 deletions test/modifier_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ class ModifierTest < ActiveSupport::TestCase
"between" => ["date", "date"]
},
"number"=> {
"is"=>["number"],
"is_less_than"=>["number"],
"is_greater_than"=>["number"],
"is_between"=>["number", "number"]
"exactly"=>["number"],
"less_than"=>["number"],
"greater_than"=>["number"],
"between"=>["number", "number"]
},
"string" => {
"contains" => ["string"],
Expand Down