Skip to content

DatePreposition is generating the wrong SQL to find NULL values #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boblail wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DatePreposition is generating the wrong SQL to find NULL values #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/date_preposition_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,14 @@ class DatePrepositionTest < ActiveSupport::TestCase
end
end

test "should use 'IS NOT NULL' rather than '!= NULL'" do
modifier = DatePreposition.new(operator: :ever, values: [])
assert_equal "\"people\".\"birthday\" IS NOT NULL",
modifier.build_arel_for(table[:birthday]).to_sql

assert_equal "values.value::date IS NOT NULL",
modifier.build_arel_for(Arel.sql("values.value::date")).to_sql
end


end