Skip to content

Conversation

@craxy2010
Copy link
Owner

fix cpplint#95: spurious "cpp should include its header file"

Copy link
Collaborator

@craxy2010u craxy2010u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

Copy link
Collaborator

@craxy2010u craxy2010u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 more change?

Copy link
Collaborator

@craxy2010u craxy2010u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 more approved

@craxy2010u
Copy link
Collaborator

Yep :)


def testIncludeItsHeader(self):
temp_directory = tempfile.mkdtemp()
cur_dir = os.getcwd()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎

gg

Comment on lines +4680 to +4682
file_path = os.path.join(test_directory, 'foo.h')
open(file_path, 'a').close()
file_path = os.path.join(test_directory, 'Bar.h')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇


def testIncludeItsHeader(self):
temp_directory = tempfile.mkdtemp()
cur_dir = os.getcwd()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎

gg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spurious "should include its header file"

3 participants