-
Notifications
You must be signed in to change notification settings - Fork 0
fix #95: spurious "cpp should include its header file" #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
craxy2010u
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
craxy2010u
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 more change?
craxy2010u
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 more approved
|
Yep :) |
|
|
||
| def testIncludeItsHeader(self): | ||
| temp_directory = tempfile.mkdtemp() | ||
| cur_dir = os.getcwd() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👎
gg
| file_path = os.path.join(test_directory, 'foo.h') | ||
| open(file_path, 'a').close() | ||
| file_path = os.path.join(test_directory, 'Bar.h') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
|
|
||
| def testIncludeItsHeader(self): | ||
| temp_directory = tempfile.mkdtemp() | ||
| cur_dir = os.getcwd() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👎
gg
fix cpplint#95: spurious "cpp should include its header file"