Fixed search for repository root directory #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the situation, where one git/svn/hg repository is located inside the directory tree of another, the search incorrectly selects the outer one instead of the inner one.
craxy2010
commented
Sep 29, 2020
Owner
Author
|
review test conversation |
craxy2010
commented
Sep 29, 2020
| os.path.exists(os.path.join(current_dir, ".hg")) or | ||
| os.path.exists(os.path.join(current_dir, ".svn"))): | ||
| root_dir = current_dir | ||
| break |
Owner
Author
There was a problem hiding this comment.
review test inline - single
craxy2010
commented
Sep 29, 2020
| os.path.exists(os.path.join(current_dir, ".hg")) or | ||
| os.path.exists(os.path.join(current_dir, ".svn"))): | ||
| root_dir = current_dir | ||
| break |
Owner
Author
There was a problem hiding this comment.
review test inline - start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the situation, where one git/svn/hg repository is located inside the
directory tree of another, the search incorrectly selects the outer one
instead of the inner one.