Skip to content

Fixes for jump to top on pages where sectionWrapperSelector goes almo… #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bessonette wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes for jump to top on pages where sectionWrapperSelector goes almo… #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions smartscroll.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,12 @@
var sectionWrapperIsVisible = function () {
var windowTop = getWindowTop();
var windowBottom = windowTop + $(window).height();
var pageHeight = $(document).height();

// Only affect scrolling if within the sectionWrapper area
if (windowBottom === pageHeight) {
return false;
}
if (
windowBottom > sectionWrapperTop
&& windowTop <= sectionWrapperBottom
Expand Down Expand Up @@ -302,6 +307,7 @@
if (
windowBottom > sectionWrapperTop
&& windowTop <= sectionWrapperBottom
&& sectionWrapperIsVisible()
) {
// Only hijack the scroll when windowTop and windowBottom are touching different slides
// `!==` instead of `<` caters for when `getSectionIndexAtWindowBottom` is `undefined`
Expand Down
2 changes: 1 addition & 1 deletion smartscroll.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.