Add LightVAE support #221
Add LightVAE support #221
Conversation
Signed-off-by: RyanOnTheInside <7623207+ryanontheinside@users.noreply.github.com>
ryanontheinside
force-pushed
the
ryanontheinside/feat/universal-input-modes-rb/05-lightvae
branch
from
9d066b3 to
8d7e973
Compare
frontend/src/hooks/useStreamState.ts
Outdated
| await Promise.allSettled([ | ||
| getPipelineSchemas(), | ||
| getHardwareInfo(), | ||
| getVaeTypes(), |
There was a problem hiding this comment.
Since we've begun the move towards pipelines defining their own schemas can we fold the VAE types into the pipeline schema instead of treat them as separate things?
Eg.
A vae_type field in the Pydantic class. AFAICT a Pydantic class can have enums such that a user of the class can inspect it to determine the allowed values - see this.
Could we do something like the above so that the pipeline schema defines allowable values for the VAE type and the frontend gets all this information as a part of the pipeline schema and can render components based on that?
Signed-off-by: RyanOnTheInside <7623207+ryanontheinside@users.noreply.github.com>
| supports_cache_management: ClassVar[bool] = False | ||
| supports_kv_cache_bias: ClassVar[bool] = False | ||
| supports_quantization: ClassVar[bool] = False | ||
| supports_vae_type: ClassVar[bool] = False |
There was a problem hiding this comment.
I know that we already have a few of these "supports_" fields, but we're also gradually cleaning up the schema.
Given that, is it possible to avoid introducing an extra "supports_" field and instead declare the vae_type field as an enum in the Pydantic class and if it exists in the schema then the pipeline implicitly supports it? See this for a starting point. Might just need to handle the parsing in the frontend here.
Rebase after merging #219