Skip to content

[Fix] when WebViewController is not called viewDidLoad, then dealloc … #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tentenlee100 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Fix] when WebViewController is not called viewDidLoad, then dealloc … #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions AXWebViewController/AXWebViewController/AXWebViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,10 +504,19 @@ - (void)dealloc {
#if AX_WEB_VIEW_CONTROLLER_USING_WEBKIT
_webView.UIDelegate = nil;
_webView.navigationDelegate = nil;
[_webView removeObserver:self forKeyPath:@"estimatedProgress"];
[_webView removeObserver:self forKeyPath:@"scrollView.contentOffset"];
[_webView removeObserver:self forKeyPath:@"title"];
// [_webView.scrollView removeObserver:self forKeyPath:@"backgroundColor"];
@try{
[_webView removeObserver:self forKeyPath:@"estimatedProgress"];
[_webView removeObserver:self forKeyPath:@"scrollView.contentOffset"];
[_webView removeObserver:self forKeyPath:@"title"];
// [_webView.scrollView removeObserver:self forKeyPath:@"backgroundColor"];
}
@catch (NSException *exception) {
NSLog(@"%@", exception.reason);
}
@finally {
NSLog(@"remove webview Observer fail");
}

#else
_webView.delegate = nil;
#endif
Expand Down