Move to v2 subscription messaging (FE BE) #7381
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| return@withContext subscriptionsDataStore.subscriptionFeatures | ||
| ?.let(featuresAdapter::fromJson) | ||
| ?.get(basePlanId) ?: emptySet() | ||
| } |
There was a problem hiding this comment.
Bug: Missing V2 fallback when tier flag toggled OFF
The flag transition logic has an asymmetry that could cause issues during rollback. When tierMessagingEnabled is ON, getFeatures falls back from V2 to V1 if V2 is empty. However, when the flag is OFF, it only reads from V1 with no fallback to V2. Combined with the fetcher which exclusively populates V2 when flag is ON (and V1 when flag is OFF), this means: if a user's app ran with the flag ON (V2 populated, V1 empty), and the flag is later toggled OFF remotely, getFeatures returns an empty set until the app restarts and the fetcher repopulates V1. This could temporarily hide subscription offers from affected users during emergency flag rollbacks.
Please tell me if this was useful or not with a 👍 or 👎.
Additional Locations (1)
There was a problem hiding this comment.
Expected scenario: Users are in legacy version, we will enable FF for v2.
- Transition should work
- We offer a fallback to cover FF change during runtime
Moving from v2 -> v1, not expected. If happens, restarting the app will fix. I think tradeoff is acceptable
cmonfortep
force-pushed
the
feature/cristian/migrate_subscription_v2_messaging
branch
from
2178318 to
8e20b1c
Compare
| * with the new tier-based payload structure supporting Plus/Pro tiers. | ||
| * The flag is exposed to FE via getFeatureConfig. | ||
| */ | ||
| @Toggle.DefaultValue(DefaultFeatureValue.FALSE) |
There was a problem hiding this comment.
Planning to change this to True before merging. Keeping false to facilitate testing scenario.
lmac012
left a comment
lmac012
left a comment
There was a problem hiding this comment.
Looks good and works as expected 👌
...ions/subscriptions-impl/src/main/java/com/duckduckgo/subscriptions/impl/RealSubscriptions.kt
Outdated
Show resolved
Hide resolved
...riptions-impl/src/main/java/com/duckduckgo/subscriptions/impl/SubscriptionFeaturesFetcher.kt
Outdated
Show resolved
Hide resolved
cmonfortep
force-pushed
the
feature/cristian/migrate_subscription_v2_messaging
branch
from
8e20b1c to
f9ac1f5
Compare
cmonfortep
force-pushed
the
feature/cristian/migrate_subscription_v2_messaging
branch
from
f9ac1f5 to
28bc230
Compare
cmonfortep
deleted the
feature/cristian/migrate_subscription_v2_messaging
branch
2 participants
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1212502267333651?focus=true
Description
Supports BE v2 features endpoint
Enables FE V2 messaging
Introduces FF for transition
Steps to test this PR
Feature 1
applicationIdSuffix ".debug"inbuild.gradle) so it can obtain subscripton products and plans from Play StoreFeature 2
tierMessagingEnabledFeature 3
applicationIdSuffix ".debug"inbuild.gradle) so it can obtain subscripton products and plans from Play StoretierMessagingEnabledUI changes
Note
Introduces tier-based subscriptions with V2 features and minimal-risk fallback.
featuresV2fetch viaSubscriptionsCachedServiceand maps toEntitlement; persists per-plan entitlements in newsubscriptionEntitlementsstore with Moshi adapterstierMessagingEnabled(default ON) to: fetch/store V2 entitlements, expose FE capability ingetFeatureConfig, and serve newgetSubscriptionTierOptionsJS messageSubscriptionsManager/SubscriptionOfferto useentitlements(andtier) while keepingfeaturesas a derived, backward-compatible view;getFeatures()now maps from entitlementsAuthRepository.getFeaturesgracefully falls back to V1 features when V2 absent; legacy feature derivation retained when flag OFFuseClientWithCacheForFeaturesFF; expands tests across manager, repository, fetcher, messaging, and UI view models to cover V2 and fallback pathsWritten by Cursor Bugbot for commit 28bc230. This will update automatically on new commits. Configure here.