Fix Unhandled Promise rejection when called with a non-existent path #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When jscodeshift is called with a path that doesn't exist, `concatAll()` gets called with `undefined`, which isn't an interable, and throws an error. This PR fixes the promise being resolved by matching it with the ignore case.
snewcomer
approved these changes
Jul 23, 2019
snewcomer
left a comment
snewcomer
left a comment
There was a problem hiding this comment.
Running up against this right now. This seems like a good fix!
|
Yes! I would love for this fix to be merged in and released, and/or the PR I raised (#339) to address the same symptom. Thanks! |
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When jscodeshift is called with a path that doesn't exist,
concatAll()gets called withundefined, which isn't an iterable, and throws an error. This PR fixes the promise being resolved by matching it with the ignore case.