Remove import of loadRcppModules from Rcpp #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salut @fmichonneau !
We are in the midth of small cleanup in Rcpp. See here for the issue and here for the PR. In essence we deprecated something years ago, it really looks like nobody uses it, and we can now remove it. I am however running a reverse dependency check right now, and one of the package using this package stumbles. You happen to have an old (and unused !!)
importFrom(Rcpp, loadRcppModules). Simply removing this from source andNAMESPACEfixes it.Is there any chance I could twist your arm to get the update to CRAN? I would be happy to 'pay the toll fee' and send you another quick PR to remove the nag that is
if that helped. (Done in #22)
Edit: And because you have quite a few reverse dependencies it would of course take those down too 😿