[pull] master from holo-routing:master #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update BFD authentication code to align with existing coding style and conventions. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Support for RFC 5303 was added in commit 4e24e43, but the northbound code was not updated to include the newly introduced extended circuit ID. Update northbound state data and notifications to populate the extended circuit ID where applicable. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
In addition to YANG validation, Holo uses code-level validation in the form of callbacks to ensure a given configuration is valid. This is necessary to express more complex validation constraints, or to reject configuration values that are not currently supported. In the current implementation, configuration validation is performed in parallel, with each component validating its associated configuration subtree. However, this has a few problems. First, validation callbacks aren't invoked when the corresponding component hasn't started yet, such as OSPF validation callbacks for an OSPF instance that isn't configured yet. Second, validation callbacks do not depend on existing state, making it simpler to validate the entire configuration in a single place. This commit refactors the code so that holod performs full configuration validation itself, instead of sending validation requests to internal components. This approach is simpler and fixes the aforementioned bug. This commit also introduces an optimization where, instead of traversing all configuration nodes and validating them one by one, the list of validation callbacks is iterated over and only the corresponding nodes in the configuration are validated. This scales much better for larger configurations. Fixes: #97 Fixes: #98 Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
The extended-lsa-support leaf is optional, so handle the case where it isn't present. As we move towards more YANG-based code generation, issues like this will be caught at compile time. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Do not unwrap the area type conversion result. Return a validation error instead when an unknown area type is provided. Fixes #98 Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )