Skip to content

Fixed issue where "reference_component_for_position" attribute would not contain the value from the file #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thiess-cristian wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed issue where "reference_component_for_position" attribute would not contain the value from the file #61

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fa1b4c
Fixed issue with ComponentPostProcessor
thiess-cristian Dec 5, 2025
81ccfd1
Added include
thiess-cristian Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions include/rexsapi/ModelHelper.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

#include <algorithm>
#include <unordered_map>
#include <unordered_set>

namespace rexsapi::detail
{
Expand Down Expand Up @@ -160,12 +161,17 @@ namespace rexsapi::detail
void process(TResult& result, const detail::TModeAdapter& mode, const rexsapi::TComponents& components,
const ComponentMapping& componentMapping) noexcept
{
static const std::unordered_set<std::string> EXCLUDED_REFERENCE_ATTRIBUTES = {
"referenced_component_id",
"reference_component_for_position"
};
for (const auto& component : components) {
TAttributes attributes;
for (const auto& attribute : component.getAttributes()) {
// TODO: maybe add new value type REFERENCE_EXTERNAL_COMPONENT
if (attribute.getValueType() == TValueType::REFERENCE_COMPONENT && attribute.hasValue() &&
attribute.getAttributeId() != "referenced_component_id") {
if (attribute.getValueType() == TValueType::REFERENCE_COMPONENT &&
attribute.hasValue() &&
EXCLUDED_REFERENCE_ATTRIBUTES.find(attribute.getAttributeId()) == EXCLUDED_REFERENCE_ATTRIBUTES.end()) {
auto id = attribute.getValue<TReferenceComponentType>();
const auto* comp = componentMapping.getComponent(static_cast<uint64_t>(id), components);
if (comp == nullptr) {
Expand Down