Update to DQL #200
Update to DQL #200
Conversation
| func startSubscription() { | ||
| subscription = ditto.store.collections().subscribe() | ||
| do { | ||
| subscription = try ditto.sync.registerSubscription(query: "SELECT * FROM system:collections") |
There was a problem hiding this comment.
are we trying to subscribe to all the collections? i.e. here we would need a list of all of the collections, then for each one register a subscription?
this is just registering a subscription to the system collection, which I am not sure we actually need to do that - its always accessible (double check me on that)
Also would that query work? the :collections part isn't misinterpreted as a value placeholder?
There was a problem hiding this comment.
We definitely don't want to subscribe to anything in this tool, the fact that the old one did is not a good thing.
|
I don't think we're handling strict mode here at all? My suggestion would be a toggle for strict mode, with default strict mode off |
|
I'd like to take a step back here and make sure we have a clear path forward here - I think the overall goal is to replace this tool entirely with a DQL editor like @biozal made in Edge Studio rather than something more piecemeal. |
|
Should I just remove the Data Browser changes from this PR and put up a new one for that change? @bplattenburg |
|
@acoyner Yes, I think that makes sense to break out |
Closes CXTOOLS-255