Fix auto-merge to only merge GitAuto PRs, not all PRs #2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auto-merge feature was incorrectly merging ALL PRs (including human-created ones) when tests passed. This was a critical bug that could auto-merge human PRs without approval. Changes: - Add check to verify PR author is GitAuto before auto-merging - Use GITHUB_APP_USER_NAME constant from config instead of hardcoding - Add test to verify human PRs are skipped for auto-merge - Update all auto-merge tests to mock GITHUB_APP_USER_NAME - Update test payloads to include required user field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto-merge feature was incorrectly merging ALL PRs (including human-created ones) when tests passed. This was a critical bug that could auto-merge human PRs without approval.
Changes: