Skip to content
This repository was archived by the owner on Jun 24, 2024. It is now read-only.

[WIP] show a warning message when a starter repo is private and user-owned #2373

Open
spinecone wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] show a warning message when a starter repo is private and user-owned #2373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/assets/javascripts/autocomplete.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions app/views/assignments/_assignment_form_options.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
oninput: "importOptions(this.value);removeErrorBox(this);",
data: { "autocomplete-search-endpoint": "github_repos" }
%>
<span class="private-user-owned-repo-message hidden-tab">We will soon only be allowing starter code repositories that belong to your classroom organization to be used for assignments. If you have any feedback about this change, let us know at [an issue url]</span>
</dd>
<dd class="dd-autocomplete-suggestions"><%= render_autocomplete_suggestions_container %></dd>
<input class="js-autocomplete-resource-id" type="hidden" name="repo_id" />
Expand Down
3 changes: 2 additions & 1 deletion app/views/autocomplete/_repository_suggestions.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
<% repos.each do |repo| %>
<li class="js-autocomplete-suggestion-item"
data-res-id="<%= repo[:id] %>"
data-res-name="<%= repo[:full_name] %>">
data-res-name="<%= repo[:full_name] %>"
data-res-private-owned-by-user="<%= repo[:private] && repo[:owner][:type] == "User" %>">
<%= repo[:private] ? octicon('lock') : octicon('repo') %>
<strong><%= repo[:full_name] %></strong>
<span><%= repo[:description] %></span>
Expand Down