Skip to content

Refactor compare router param parse #36105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
lunny wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

Refactor compare router param parse #36105

lunny wants to merge 30 commits into from

Conversation

@lunny
Copy link
Member

@lunny lunny commented Dec 8, 2025 •
edited
Loading

Bugs fix extracted to #36166

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 8, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 8, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Dec 8, 2025
techknowlogick
techknowlogick reviewed Dec 8, 2025
View reviewed changes
@lunny @techknowlogick
Update routers/common/compare_test.go
44925e3 
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com>
@a1012112796
Copy link
Member

a1012112796 commented Dec 10, 2025

please have a look at #36116

@lunny lunny marked this pull request as ready for review December 10, 2025 23:25
@lunny lunny changed the title Refactor compare router param parse Refactor compare router param parse and fix bugs Dec 11, 2025
@lunny
Copy link
Member Author

lunny commented Dec 11, 2025

please have a look at #36116

This has been included and it's ready to review now.

@lunny lunny added the type/bug label Dec 11, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2025
@lunny lunny added backport/done All backports for this PR have been created backport/v1.25 labels Dec 12, 2025
silverwind
silverwind reviewed Dec 12, 2025
View reviewed changes
silverwind
silverwind reviewed Dec 12, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 13, 2025
wxiaoguang
wxiaoguang reviewed Dec 13, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Dec 15, 2025
View reviewed changes
@wxiaoguang
Update routers/api/v1/repo/pull.go
b7cca4c 
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
wxiaoguang
wxiaoguang reviewed Dec 15, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Dec 15, 2025
View reviewed changes
@lunny lunny mentioned this pull request Dec 15, 2025
Merged
@lunny lunny removed backport/done All backports for this PR have been created backport/v1.25 type/bug labels Dec 15, 2025
@lunny lunny changed the title Refactor compare router param parse and fix bugs Refactor compare router param parse Dec 15, 2025
@lunny lunny marked this pull request as draft December 15, 2025 20:16
lunny added a commit that referenced this pull request Dec 17, 2025
@lunny
Fix bug when creating pull request (#36166)
efd5dd4 
Extract from #36105 

Fix #36116
Fix #35912
Fix #20906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@silverwind silverwind silverwind approved these changes

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

@a1012112796 a1012112796 Awaiting requested review from a1012112796

@kerwin612 kerwin612 Awaiting requested review from kerwin612

@Zettat123 Zettat123 Awaiting requested review from Zettat123

Assignees

No one assigned

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

8 participants

@lunny @a1012112796 @wxiaoguang @silverwind @techknowlogick @kerwin612 @Zettat123 @GiteaBot