This repository was archived by the owner on Dec 23, 2025. It is now read-only.
Rename with-remote-method to client #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigoo
approved these changes
Dec 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I remember correctly, John when preparing for no-sql db implementation using types-script had some difficulty in understanding the name of the return type of
CounterAgent.get(this.name)which wasWithRemoteMethods<CounterAgent>.Probably I named it like that because in the beginning it's type was just
CounterAgentitself and once I added trigger and schedule we needed it to be "wrapper" type with just these extra methods, and went forWithRemoteMethods<CounterAgent>.Anyway!
Client<CounterAgent>is closer toCounterAgentClientin Rust. And more understandable