Skip to content

Fix bug: Handle empty iterator in _print_stream function #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arJ-V wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix bug: Handle empty iterator in _print_stream function #456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion gemma/gm/text/_chat_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,10 +225,16 @@ def _print_stream(
) -> _sampler.SamplerOutput:
"""Prints the streaming output."""
text_tokens = []
last_state = None
for state in out:
last_state = state # Track the last state to avoid undefined variable
text_tokens.append(state.text)
if state.text == '<end_of_turn>': # Last token is not printed.
continue
print(state.text, end='', flush=True)
out = dataclasses.replace(state, text=''.join(text_tokens)) # pylint: disable=undefined-variable,undefined-loop-variable
if last_state is None:
raise ValueError(
'Empty iterator passed to _print_stream. No states were yielded.'
)
out = dataclasses.replace(last_state, text=''.join(text_tokens))
return out