feat(secretserver): use official secretserver library #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pd-gov
requested review from
itscaro,
mumoshu,
xiaomudk and
yxxhero
as code owners
Signed-off-by: Dargel, Philipp <philipp.dargel@governikus.de>
pd-gov
force-pushed
the
feature/secretserver
branch
from
23f577f to
0d0c416
Compare
Contributor
Author
|
Hm, I don't get the lint issue. The file is formatted using the vs code golang extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that the vendor provides an official library. So I replaced the raw http implementation with that.
Additional changes:
tssin code and environment variables.The changes are tested against an on-prem instance. The library also allows easier use with their cloud offering. Support is implemented but could not be tested.