feat(server,primary-ip): deprecate datacenter #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
- Coverage 72.67% 72.61% -0.06%
==========================================
Files 302 302
Lines 10953 10966 +13
==========================================
+ Hits 7960 7963 +3
- Misses 2125 2133 +8
- Partials 868 870 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apricote
requested changes
Dec 22, 2025
| cmd.Flags().String("location", "", "Location of Primary IP") | ||
| _ = cmd.RegisterFlagCompletionFunc("location", cmpl.SuggestCandidatesF(client.Location().Names)) | ||
|
|
||
| cmd.Flags().String("datacenter", "", "Datacenter (ID or name) (deprecated)") |
Member
There was a problem hiding this comment.
Could you add a snippet to the Long description that describes the deprecation of the flag and links to the changelog entry? Similar to https://github.com/hetznercloud/hcloud-cloud-controller-manager/blob/main/docs/guides/quickstart.md#quick-start
Same for all other commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.hetzner.cloud/changelog#2025-12-16-phasing-out-datacenters