-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: rename repo from java-api to java-api-17 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rename default branch from 17 to main
Reviewer's GuideUpdates repository metadata and documentation to reflect the rename from File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- In the root README, the
[java-api-stubs]link still points togithub.com/ignition-devs/java-api/tree/main/java-api-stubsinstead of the renamedjava-api-17repository, which will likely lead to a broken or outdated link. - The added
"mypy[python2]==0.971"in thepython3 -m pip installexample forjava-api-stubsmay be surprising for users installing only the stubs; consider documenting why it is required there or moving it into project configuration (e.g., extras/requirements) rather than the README install snippet.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the root README, the `[java-api-stubs]` link still points to `github.com/ignition-devs/java-api/tree/main/java-api-stubs` instead of the renamed `java-api-17` repository, which will likely lead to a broken or outdated link.
- The added `"mypy[python2]==0.971"` in the `python3 -m pip install` example for `java-api-stubs` may be surprising for users installing only the stubs; consider documenting why it is required there or moving it into project configuration (e.g., extras/requirements) rather than the README install snippet.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
rename default branch from 17 to main
Summary by Sourcery
Update repository references and CI configuration to reflect the rename to java-api-17 and the new main default branch.
Enhancements:
CI: