fix: update to eip 7594 blob handling #202
Open
+35
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanlott
changed the title
dylanlott
changed the title
Member
|
isn't this already ticketed for @Evalir ? where are we at there? |
dylanlott
changed the title
dylanlott
changed the title
prestwich
requested changes
Dec 20, 2025
Member
|
@prestwich this ticket hasn't really been spec'ed yet. I've asked a question or two there which we haven't answered. while the current PR works I'd recommend we hash it out on linear before acting further, since we shipped some peripheral alloy work to make this easier |
Contributor
Author
|
Follow up work spec'd in ENG-1649 |
Contributor
Author
|
This PR at latest commit has been tested and confirmed working in devent with the roundtrip script. |
Evalir
reviewed
Dec 23, 2025
| use tracing::{Instrument, debug, debug_span, error, instrument}; | ||
|
|
||
| /// Type alias for a EIP 7594 compatible blob sidecar transaction envelope. | ||
| type SubmitEnvelope7594 = EthereumTxEnvelope<TxEip4844Variant<BlobTransactionSidecarEip7594>>; |
Comment on lines
+124
to
+125
| let sidecar = self.build_sidecar().await?; | ||
| let input = self.build_input().await?; |
Member
There was a problem hiding this comment.
join!(self.build_sidecar(), self.build_input() to chain both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: update to eip 7594 blob handling
This PR changes the
prep_transactionto create a EIP-7594 compatible blob sidecar.Closes ENG-1582
Related to ENG-1562