-
Notifications
You must be signed in to change notification settings - Fork 55
Add note about INNGEST_SERVE_HOST to host.docker.internal #1193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
djfarrelly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some potential edits for clarity.
The other part that we may want to consider on another pull request is "configuring your application" or similar section as if you're running it on your network, it would be whatever hostname that your machine had, e.g. inngest:8288 within the docker network or some other sort of hostname if you're in k8s, etc.
| If you are locally testing your Inngest app with the docker compose setup, you will likely need to set [`INNGEST_SERVE_HOST`](/docs/sdk/environment-variables#inngest-serve-host) to docker's [special host DNS name `host.docker.internal`](https://docs.docker.com/desktop/features/networking/#i-want-to-connect-from-a-container-to-a-service-on-the-host), e.g. | ||
|
|
||
| ``` | ||
| INNGEST_SERVE_HOST=http://host.docker.internal:3000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd want to use INNGEST_BASE_URL similar to: https://github.com/inngest/website/pull/1193/files#diff-9726d7baf8dd64dcaff63a7266cfe55483d75a537d1fec05e382f50056ace910R164
Also, isn't the port 8288?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the env var that tells the inngest server where to call the SDK at /api/inngest, without it it tries to call localhost:3000/api/inngest which it can't access from inside the docker container. But users will most likely want to set all those env variables too, should I copy them here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least that's what I think it was... it's confusing that the example port at https://www.inngest.com/docs/sdk/environment-variables#inngest-serve-host is 8288
When I didn't have this set I was seeing
and then lots of errors about being able to reach the SDK, but with it set I saw this
No description provided.