feat: Implement automated testing with GHA #32
Conversation
changed implementation, started redocumenting and testing
|
Thanks @benjoe1126 ! This is a highly anticipated enhancement. I am busy these days, but I will check it shortly. |
levaitamas
left a comment
levaitamas
left a comment
There was a problem hiding this comment.
Very cool stuff! I went through the changes and left some comments. These are mostly minor notes and comments are welcome. I plan to run these actions in a fork to better understand the components and the action chains.
| TAGS: ${{ inputs.tags }} | ||
| ACTION_PATH: ${{ github.action_path }} | ||
| run: | | ||
| bash $GITHUB_ACTION_PATH/build.sh |
There was a problem hiding this comment.
If we want to stick to the env var, this line makes more sense to me:
| bash $GITHUB_ACTION_PATH/build.sh | |
| bash $ACTION_PATH/build.sh |
BTW do we need this env var? This should work too:
| bash $GITHUB_ACTION_PATH/build.sh | |
| bash ${{ github.action_path }}/build.sh |
There was a problem hiding this comment.
I ended up removing the ACTION_PATH env var, can't quite remember why it was there to begin with, but it was not used anyway.
The GITHUB_ACTION_PATH has to stay tho, as ${{ github.action_path }} is a github context directive and can't be interpreted by the script executed on the runner.
There was a problem hiding this comment.
The GITHUB_ACTION_PATH has to stay tho, as ${{ github.action_path }} is a github context directive and can't be interpreted by the script executed on the runner.
The shell script does not use the env var; using the context directive in this line is fine as the GHA runner reads it.
| inputs: | ||
| kube-distro: | ||
| type: choice | ||
| description: "The type of kubernetes distribution to use, i.e minikube, kind" |
There was a problem hiding this comment.
Cool! Note: on the long run we will enable just one option to simplify debugging.
There was a problem hiding this comment.
The problem is: we use minikube now, but kind is more performant.
.github/workflows/test-labs.yaml
Outdated
|
|
||
| kubernetes-tests: | ||
| type: string | ||
| description: "The name(s) of the kubernetes test(s) to be run, if you want to run multiple, provide them separated with spaces, e.g 'kvstore splitdim', if you provide 'all', it will execute all kubernetes tests" |
There was a problem hiding this comment.
We have three cases if I recall correctly: "helloworld" "splitdim", "kvstore" I would put a phrasing like this:
| description: "The name(s) of the kubernetes test(s) to be run, if you want to run multiple, provide them separated with spaces, e.g 'kvstore splitdim', if you provide 'all', it will execute all kubernetes tests" | |
| description: "Kubernetes tests to be run. Options: 'helloworld' 'splitdim', 'kvstore', 'all'. if you want to run multiple, provide them separated with spaces (e.g., 'kvstore splitdim'); 'all' means execute all tests" |
levaitamas
changed the title
made report generating function separated report logic into its own file changed template html and also fixed issue with templating removed needless function call fixed report and modified the makefile fixed report target added report action testing out workflow testing workflo2 now properly runs test on push testing out report fixed branch
benjoe1126
force-pushed
the
automated-testing
branch
from
3fa6679 to
994e8ee
Compare
Created github workflows that test homework exercises and labor exercises as well