Skip to content

Conversation

@0xMuluh
Copy link
Collaborator

@0xMuluh 0xMuluh commented Sep 1, 2025

ping #771

Signed-off-by: Daena Rys <rysdaena8@gmail.com>
@0xMuluh 0xMuluh requested a review from TuomasBorman September 1, 2025 06:50
@TuomasBorman
Copy link
Contributor

@Daenarys8 Can you check why the check in test-5prevalence.R fails? It works in my local computer.

Copilot AI review requested due to automatic review settings December 8, 2025 08:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

mm-hak and others added 6 commits December 8, 2025 11:17
Co-authored-by: Tuomas Borman <60338854+TuomasBorman@users.noreply.github.com>
…is: "Correspondance" → "Correspondence" (#792)

Co-authored-by: Tuomas Borman <60338854+TuomasBorman@users.noreply.github.com>
Signed-off-by: Daena Rys <rysdaena8@gmail.com>
Signed-off-by: Daena Rys <rysdaena8@gmail.com>
Signed-off-by: Daena Rys <rysdaena8@gmail.com>
@0xMuluh
Copy link
Collaborator Author

0xMuluh commented Dec 8, 2025

@TuomasBorman
The grouping factor f was incorrectly constructed using rownames(x)[match(...)] which indexed back into rownames(x) instead of rownames(res). This caused sequences to be mapped to wrong groups when building consensus reference sequences.

Fix: Changed to rownames(res)[match(rownames(x), rownames(res))] to correctly map each taxon to its corresponding prevalence group.

Test update: The test expectation for the Alistipes consensus sequence was updated because:

  • The test was previously skipped (miaTime wasn't in Bioc yet)
  • The expected value SCRAG... was stale
  • The actual consensus from all 16 Alistipes sequences (including 4 unusual ones in SilvermanAGutData) is BCNMK...

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@TuomasBorman
Copy link
Contributor

Thanks for detailed comments. I made couple of changes, there was logical issue that I found based on your comments.

@TuomasBorman TuomasBorman merged commit 9514328 into devel Dec 8, 2025
3 checks passed
@TuomasBorman TuomasBorman deleted the tm branch December 8, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants