Skip to content

fix build issues: #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
KalyanKona wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix build issues: #158

KalyanKona wants to merge 1 commit into from

Conversation

@KalyanKona
Copy link

@KalyanKona KalyanKona commented Jul 12, 2022

  1. redefinition from wbcl
  2. add preprocessor for dllexport
  3. rename the conflicting functions

@KalyanKona
fix build issues:
ff906b2 
1) redefinition from wbcl
2) add preprocessor for dllexport
3) rename the conflicting functions
RonaldAi
RonaldAi approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@RonaldAi RonaldAi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

ComputerKarate
ComputerKarate reviewed Jul 25, 2022
View reviewed changes
PCPTool.v11/dll/PCPWbcl.cpp

//
// Move to the first log entry after the descriptor.
// WbclApiMoveToNextElement() does boundary checks.
Copy link

@ComputerKarate ComputerKarate Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the reference in this comment need to change as well?
It could be confusing to leave a call that is similar but not the same.

ComputerKarate
ComputerKarate reviewed Dec 6, 2022
View reviewed changes
PCPTool.v11/inc/TpmAtt.h
_Field_size_bytes_(PolicyNameLength + DigestLength)
BYTE VarLengthData[ANYSIZE_ARRAY];

} SIPAEVENT_SI_POLICY_PAYLOAD, *PSIPAEVENT_SI_POLICY_PAYLOAD;
Copy link

@ComputerKarate ComputerKarate Dec 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

(PSIPAEVENT_SI_POLICY_PAYLOAD)pbSipaData;

is referenced in Support.cpp ~line 260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ComputerKarate ComputerKarate ComputerKarate left review comments

@RonaldAi RonaldAi RonaldAi approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KalyanKona @RonaldAi @ComputerKarate