Fixture testdatapath, refactor and unify testdatapath handling #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d usage: - pytest fixture (adding code and info to conftest.py) - compute the testdata_path in only one place - provide used test files as constants
…d usage: - to non test code we shall discuss wether testdata makes sense at all - here i have implemented a small workaround with reusage of conftest.py via a wrapper
Collaborator
|
Contributor
Author
oops, they should not be in extra subdir. Sorry, my fault. It meant to be /tests only.
yes. I always feel bad when i do suppressions to hide hacks or workarounds like that. Will remove it.
passing explicit is a good idea, let me try that. (explicit is better than implicit ;-) |
- removed dependency on tests aka conftest.py - added explicit arguments for passing in testdata and validation logic
- adopted conftest.py to use only parent instaed of parent.parent
…t the subprocess needs the full environment (PATH, PYTHONPATH, system libraries, etc.) to import Python modules correctly. Fix: Changed the fixture to inherit the full parent environment (dict(os.environ)) instead of building a minimal one.
gvanrossum
reviewed
Jan 2, 2026
Comment on lines
+183
to
+185
| "Either --database or --podcast-index must be specified. " | ||
| "Use --podcast-index to specify the path to podcast index files " | ||
| f"(e.g., '{_EXAMPLE_PODCAST_INDEX}')." |
Collaborator
There was a problem hiding this comment.
Oh, excellent. In practice the server almost always should use --database, which should be pre-filled by running one of the ingest tools.
Comment on lines
+265
to
+271
| parser.add_argument( | ||
| "-p", | ||
| "--podcast-index", | ||
| type=str, | ||
| default=None, | ||
| help="Path to podcast index files (excluding '_data.json' suffix), " | ||
| f"e.g., '{_EXAMPLE_PODCAST_INDEX}'", |
Collaborator
There was a problem hiding this comment.
At some point in the future we should be able to remove --podcast-index altogether, but not yet (and the test uses it).
tests/test_mcp_server.py
Outdated
| # Parse response (it should be JSON with success, answer, time_used) | ||
| import json | ||
|
|
||
| print(f"Response text: {response_text}") |
Collaborator
There was a problem hiding this comment.
Do you still need this debug print?
Comment on lines
93
to
103
| # Pass through environment variables needed for authentication | ||
| # otherwise this test will fail in the CI on Windows only | ||
| if not (server_params.env) is None: | ||
| server_params.env.update( | ||
| { | ||
| k: v | ||
| for k, v in os.environ.items() | ||
| if k.startswith(("AZURE_", "OPENAI_")) or k in ("CREDENTIALS_JSON",) | ||
| } | ||
| ) | ||
|
|
Collaborator
There was a problem hiding this comment.
I hope that you're right that we don't need this any more.
Contributor
Author
There was a problem hiding this comment.
Ups, sorry. This is still necessary for ci in windows. I will put it pack.
gvanrossum
approved these changes
Jan 2, 2026
…rver, or windows ci - removed debug output
gvanrossum
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a possible solution for #146
for details/question of implementation approach, please check #146