Skip to content

CI with Online/Offline tests #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gvanrossum merged 8 commits into from
Jan 4, 2026
Merged

CI with Online/Offline tests #151

gvanrossum merged 8 commits into from
Jan 4, 2026
+116 −16

Conversation

@robgruen
Copy link
Collaborator

@robgruen robgruen commented Jan 4, 2026

image

@robgruen robgruen marked this pull request as ready for review January 4, 2026 01:02
@robgruen robgruen requested a review from gvanrossum January 4, 2026 01:02
@robgruen
Copy link
Collaborator Author

robgruen commented Jan 4, 2026

@gvanrossum-ms , I'm assuming the tests will just skip if there are no keys (I was lazy and didn't check). If not, we'll want to make that update before merging this.

@gvanrossum
Copy link
Collaborator

gvanrossum commented Jan 4, 2026 •
edited
Loading

@gvanrossum-ms , I'm assuming the tests will just skip if there are no keys (I was lazy and didn't check).

Yes, any test that needs a secret uses the really_needs_auth fixture which skips the test if no secret is found in the expected environment variables.

gvanrossum
gvanrossum approved these changes Jan 4, 2026
View reviewed changes
Copy link
Collaborator

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's try this!

@gvanrossum gvanrossum merged commit f997512 into main Jan 4, 2026
16 checks passed
@gvanrossum gvanrossum deleted the dev/robgruen/workflow_update5 branch January 4, 2026 16:29
This was referenced Jan 4, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robgruen @gvanrossum