Refined parser error messages for flags given = values
#14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves the clarity of argument parser messages when a boolean flag is incorrectly provided with a value using `=`. Previously, cases like `-f=val` or `--flag=value` would produce misleading messages such as ‘unknown option '-f'’ even if the flag exists. Now, the parser reports more precise messages: - `unexpected '=' for option '-f'` - `unexpected '=' for option '--flag'` - `unexpected '=' in combined short options '-ff'`
zefir-git
changed the title
= values= values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the clarity of argument parser messages when a boolean flag is incorrectly provided with a value using
=.Previously, cases like
-f=valor--flag=valuewould produce misleading messages such as ‘unknown option '-f'’ even if the flag exists. Now, the parser reports more precise messages:unexpected '=' for option '-f'unexpected '=' for option '--flag'unexpected '=' in combined short options '-ff'