Skip to content

Conversation

@glensc
Copy link
Contributor

@glensc glensc commented Jan 30, 2022

Scenario, where need to really debug HTTP headers, are perhaps when developing this library. This is never useful for end-users and could cause leaking the tokens when sharing logs:

refs:

@player8472
Copy link

maybe add a switch in config which is deactivated by default.

It is sometimes useful to the user when working with multiple instances to check for cross-contamination of config.

@glensc
Copy link
Contributor Author

glensc commented Jan 30, 2022

this project doesn't support instances, at least not in v3

@glensc
Copy link
Contributor Author

glensc commented Feb 13, 2022

Here's are more examples where user shared their tokens just because they didn't know:

glensc added a commit to glensc/python-pytrakt that referenced this pull request Oct 24, 2022
@glensc
Copy link
Contributor Author

glensc commented Oct 24, 2022

Carried to my fork:

@glensc glensc changed the title Privacy: Don't log headers to protect privacy [python-pytrakt] Privacy: Don't log headers to protect privacy Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants