Skip to content

Update PaginatedThemeSelector accessibility #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anna-yeddi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update PaginatedThemeSelector accessibility #1069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe663db
Update PaginatedThemeSelector index.js to be more accessible
anna-yeddi Oct 25, 2024
81def26
Update PaginatedThemeSelector index.scss for better visibility of con…
anna-yeddi Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/web/lib/components/PaginatedThemeSelector/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export const PaginatedThemeSelector = ({
});

const footerPager = pageCount > 1 && (
<div className="page-selector">
<div className="page-selector" role="navigation" aria-label="pagination">
<button
className={classNames("previous", { disabled: prevDisabled })}
disabled={prevDisabled}
Expand All @@ -92,7 +92,10 @@ export const PaginatedThemeSelector = ({
"current-page": idx === currentPage
})}
onClick={() => setCurrentPage(idx)}
title={`Page ${idx + 1}`}
title={`Page ${idx + 1} of ${pageCount}`}
aria-current={
currentPage ? "page" : "false"
}
/>
))}
<button
Expand Down
3 changes: 1 addition & 2 deletions src/web/lib/components/PaginatedThemeSelector/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
button.page {
&::before {
border-radius: 8px;
border: 2px solid var(--grey-40);
border: 2px solid var(--grey-50);
box-sizing: border-box;
content: "";
height: 10px;
Expand All @@ -59,7 +59,6 @@
background-position: center center;
background-repeat: no-repeat;
background-size: 10px 18px;
opacity: .7;
transition: opacity 125ms;

&:hover {
Expand Down