Vehicles locations

[mmathieum]

• Real-time🛰️ vehicle locations/positions 🚌  mtransit-for-android#80

Tasks

• which FF to torn ON to export trip_id?
• ...

[gemini-code-assist]

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the data model by introducing a dedicated MTrip data structure, which represents individual vehicle journeys. These changes are integrated throughout the data parsing, processing, and generation pipeline, laying the groundwork for more granular management of vehicle trip information. Additionally, existing data serialization and sorting mechanisms for schedules and service dates have been refactored to be more efficient and flexible, utilizing feature flags for conditional logic.

Highlights

• New MTrip Data Structure: Introduced a new MTrip data class to represent individual vehicle trips, including route, direction, service, and trip identifiers. This new structure is integrated into the data parsing and generation process.
• Data Processing & Serialization Enhancements: The system now processes and serializes MTrip objects, and existing MSchedule and MServiceDate data handling has been refactored. This includes updates to sorting logic and file output, often leveraging new feature flags for conditional behavior and optimization.
• Code Refinements: Minor code improvements were made, such as fixing an off-by-one error in prepared statement indexing in DBUtils.kt and streamlining conditional query string generation for better readability and conciseness.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for MTrip objects and includes several refactorings. The changes are mostly positive, especially the adoption of try-with-resources and explicit comparators, which improve code quality. However, I've identified a few issues that should be addressed:

• Style Violations: In DBUtils.kt, there are some style issues that go against Kotlin conventions and reduce readability.
• Bugs: There's a recurring bug in DBUtils.kt where a boolean flag is not updated, which could lead to incorrect SQL queries in the future.
• Inconsistency: The new MTrip.kt class has an opportunity for improvement in its compareTo implementation to align with the project's coding style and fix a misleading comment.

I have provided specific comments and suggestions to resolve these points.