Fixed scientific notation bug when reading OBS sheets. #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many OBS applications save cells with long numbers in a loose scientific notation format, this means any cell with a float or double length number will be transformed into a relatively close but not correct scientific notation. When reading this file later if you attempt to use that number from the cell it will be completely different than what you actually put in it since it was saved with an incorrect scientific notation. The real number is saved as an office:value attribute attached to the table cell. If a office:value attribute is found on a cell we should use that value instead to avoid format bugs like long numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scientific Notation Bug / Format Bugs:
Many OBS applications save cells with long numbers in a loose scientific notation format, this means any cell with a long, float, or double length number will be transformed into a relatively close but not correct scientific notation.
Example:
612205820123becomes6.12206E+11but so does any number of the same length if it starts with6122058. This effectually destroys tracking numbers that do not include letters for example (FedEx).Easy Solution:
The real number is saved as an
office:valueattribute attached to the table cell. If aoffice:valueattribute is found on a table cell we simply need to use that value instead to avoid format bugs like this one; as well as any other bugs I may not have found yet, after all they (the OBS standards people) created theoffice:valueattribute for a reason.PS:
@nuovo - It seems pull request are going unanswered. I don't mind taking over this repo if you don't have time?