-
Notifications
You must be signed in to change notification settings - Fork 9
Add Q&A entry for preview #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Leonidas-from-XIV
wants to merge
3
commits into
ocaml-dune:main
Choose a base branch
from
Leonidas-from-XIV:preview-rebrand-qa
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Q&A entry for preview #179
Leonidas-from-XIV
wants to merge
3
commits into
ocaml-dune:main
from
Leonidas-from-XIV:preview-rebrand-qa
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marek Kubica <marek@tarides.com>
Alizter
reviewed
Nov 26, 2025
Alizter
reviewed
Nov 26, 2025
Signed-off-by: Marek Kubica <marek@tarides.com>
Alizter
approved these changes
Nov 26, 2025
shonfeder
reviewed
Nov 26, 2025
| <ul> | ||
| <li><var>"DUNE_CONFIG__PORTABLE_LOCK_DIRS"</var>" has been incorporated into mainline Dune, it is always enabled."</li> | ||
| <li><var>"DUNE_CONFIG__PKG_BUILD_PROGRESS"</var>" has been incorporated into mainline Dune, it is enabled when running Dune with "<code>"--display=short"</code>"."</li> | ||
| <li><var>"DUNE_CONFIG__LOCK_DEV_TOOL"</var>" is not enabled anymore but can still be set in the environment. To use dev-tools use "<code>"dune tools"</code>" while we work for better support for dev-tools."</li> |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's clear from the name of the config or this description what this feature did. It makes it sound like dev tools are not really supported at all without this feature. But that's not true. So I think, if this is to be included, we have to be more precise:
Suggested change
| <li><var>"DUNE_CONFIG__LOCK_DEV_TOOL"</var>" is not enabled anymore but can still be set in the environment. To use dev-tools use "<code>"dune tools"</code>" while we work for better support for dev-tools."</li> | |
| <li><var>"DUNE_CONFIG__LOCK_DEV_TOOL"</var>" is not enabled anymore but can still be set in the environment. This features makes dev tools automatically installed when they are invoked. E.g., running "<code>dune fmt</code>` will automatically install `ocamlformat`. Without this feature, one simply has to run `dune tools install ocamlformat` first. To use and install dev tools run "<code>"dune tools"</code>" "</li> |
shonfeder
reviewed
Nov 26, 2025
Co-authored-by: Shon Feder <shon.feder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it might be nice for continuity to explain to people why, when they go to
preview.dune.buildthey get the nightly. So I added an entry to the FAQ.Feel free to close it if we decide to just drop the preview branding altogether, to avoid any possible confusion.