Skip to content

Conversation

@Leonidas-from-XIV
Copy link
Contributor

I think it might be nice for continuity to explain to people why, when they go to preview.dune.build they get the nightly. So I added an entry to the FAQ.

Feel free to close it if we decide to just drop the preview branding altogether, to avoid any possible confusion.

Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
<ul>
<li><var>"DUNE_CONFIG__PORTABLE_LOCK_DIRS"</var>" has been incorporated into mainline Dune, it is always enabled."</li>
<li><var>"DUNE_CONFIG__PKG_BUILD_PROGRESS"</var>" has been incorporated into mainline Dune, it is enabled when running Dune with "<code>"--display=short"</code>"."</li>
<li><var>"DUNE_CONFIG__LOCK_DEV_TOOL"</var>" is not enabled anymore but can still be set in the environment. To use dev-tools use "<code>"dune tools"</code>" while we work for better support for dev-tools."</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's clear from the name of the config or this description what this feature did. It makes it sound like dev tools are not really supported at all without this feature. But that's not true. So I think, if this is to be included, we have to be more precise:

Suggested change
<li><var>"DUNE_CONFIG__LOCK_DEV_TOOL"</var>" is not enabled anymore but can still be set in the environment. To use dev-tools use "<code>"dune tools"</code>" while we work for better support for dev-tools."</li>
<li><var>"DUNE_CONFIG__LOCK_DEV_TOOL"</var>" is not enabled anymore but can still be set in the environment. This features makes dev tools automatically installed when they are invoked. E.g., running "<code>dune fmt</code>` will automatically install `ocamlformat`. Without this feature, one simply has to run `dune tools install ocamlformat` first. To use and install dev tools run "<code>"dune tools"</code>" "</li>

Co-authored-by: Shon Feder <shon.feder@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants