Serve install script (only) from Dream server #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the install script from the
get.dune.buildserver to the script served bynightly.dune.build.The previous setup used to copy the
installscript toget.dune.buildas part of the daily sync action, but this has some distinct disadvantagessyncaction to run until the new version is deployed. This two step process is tricky because it is easy to forget to run the action and then the script will only be updated on the next run (which might only happen after a few days if no changes to dune occur). This means that it can take multiple days until a change happens and things can be broken for a longer time (e.g. change over the weekend)get.dune.buildis used to host the binaries, but the fact that the install script is served by both thebinary-distributionDream app (which serves the most currently deployedmainversion) as well asget.dune.build(the latest version from the github action) is confusing. This simplifies the code base to always just use one of them.