This repository was archived by the owner on Jan 27, 2019. It is now read-only.
conf/u-boot.conf: make UBOOT_IMAGE use flag dependent. #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ## @var UBOOT_IMAGE Name of the image to build. Is u-boot.bin by default. | ||
| UBOOT_IMAGE ?= "u-boot.bin" | ||
| UBOOT_IMAGE ?= "${USE_uboot_image}" |
Contributor
There was a problem hiding this comment.
Could you add
DEFAULT_USE_uboot_image = "u-boot.bin"
Which should be a sane default, and give us backwards compatibility.
Author
|
I am wondering if I should add a use flag for |
Contributor
|
Sounds like a good idea. |
Use use flags instead of a variable override in machine.conf or whatever. Variables in machine.conf will propagate to all signatures whereas use flags is only relavant for specific recipes.
Author
|
Updated with more use flags |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use use flags instead of a variable override in machine.conf or whatever.
Variables in machine.conf will propagate to all signatures whereas use
flags is only relavant for specific recipes.